Ross Patterson [10/Dec/07 03:20 PM] Reopening per email with Ruben.

Ross Patterson [10/Dec/07 03:20 PM] Email from me to Ruben Willams on 2007-10-05: We've been using the <converters> support for a few days - we're lucky that our AccuRev userids exactly match our Active Directory usernames. But from looking at the code, I've been wondering if it isn't just a little too specialized. Taking FilteredSourceControl's include/exclude mechanism as an example, it occurred to me that we might refactor EmailConverter (ReflectorType "converter") into an IEmailConverter interface and a RegularExpressionEmailConverter implementation (ReflectorType "regexConverter"?), allowing for other implementations. Other implementations might involve interrogating some other system (e.g., Active Directory), or a more-complex programming task that regular expressions can't handle.

Ross Patterson [10/Dec/07 03:22 PM] Response from Ruben to me on 2007-10-05: Nice to hear that the converter is good addition. For your remark about the refactoring : sounds good to me. This way it is probably possible to include Alex's Active Directory program. About the filtered source control ,you're probably talking about the UserFilter element. I never used the filtered source control block, just to make this clear ;-) As far as I can see from the documentation, it specifies user names, not email addresses. So i do not see the benefit/change for the source control block. Anyway I would say go ahead, it's open source anyway ;-)

Ross Patterson [10/Dec/07 03:24 PM] Subversion revision #3550 refactors the EMailConverter class into an IEmailConverter interface and an EmailRegexConverter class. The <converter> element inside the <converters> section is now known as <regexConverter>.