History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CCNET-1650
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: Ruben Willems
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
CruiseControl .NET

failed integration and exception during integration must be split in the email publisher

Created: 23/Jul/09 03:15 PM   Updated: 25/Jul/10 12:49 PM
Return to search
Component/s: None
Affects Version/s: 1.4
Fix Version/s: 1.5.0 CTP

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
Issue Links:
Dependency
This issue Depends on:
CCNET-1046 Email publisher ignores IntegrationSt... Major Closed
 


 Description  « Hide
Regarding this docs
http://confluence.public.thoughtworks.org/display/CCNET/Email+Publisher

there is 'Exception' notification. That works well (except for
modifiers, but thats not documented either).

But it can't be currenly possible to send all exception states to 1.
group _only_ and failed builds to 1. and 2. group oth. Like this:

                   <group name="buildmaster">
                          <notifications>
                               <notificationType>Always</notificationType>
                          </notifications>
                   </group>
                   <group name="developers">
                          <notifications>
                               <notificationType>Failed</notificationType>
                               <notificationType>Success</notificationType>
                          </notifications>
                   </group>

I think its quite common request to _not_ send exception to developers
(since they can't handle it anyway).


Failed are now considered as 'Failure'+'Exception', which is not
documented well.

Excerpt from EmailMessage.cs:
               AddRecipients(recipients,
EmailGroup.NotificationType.Always);
               if (BuildStateChanged())
                   AddRecipients(recipients,
EmailGroup.NotificationType.Change);
               if ((result.Status == IntegrationStatus.Failure) ||
(result.Status == IntegrationStatus.Exception))
                   AddRecipients(recipients,
EmailGroup.NotificationType.Failed);
               if (result.Status == IntegrationStatus.Success)
                   AddRecipients(recipients,
EmailGroup.NotificationType.Success);
               if (result.Fixed)
                   AddRecipients(recipients,
EmailGroup.NotificationType.Fixed);
               if (result.Status == IntegrationStatus.Exception)
                   AddRecipients(recipients,
EmailGroup.NotificationType.Exception);

Changed by request on http://jira.public.thoughtworks.org/browse/CCNET-1046
I dont think thats good change, but ok. We can add another
notification for 'Failure' only, perhaps?


 All   Comments   Work Log   Change History      Sort Order:
Ruben Willems [23/Jul/09 03:15 PM]
from 1.5 onwards, you can specify which states must be mailed per group,
so there is no more need to couple failed and exception into 1

Change by Ruben Willems [23/Jul/09 03:15 PM]
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Change by Ruben Willems [23/Jul/09 03:17 PM]
Link This issue Depends on CCNET-1046 [ CCNET-1046 ]

Change by Ruben Willems [25/Jul/10 12:49 PM]
Status Resolved [ 5 ] Closed [ 6 ]