|
|
|
As threatened, I have tweaked my earlier patch with the following changes:
* AntOutputWidget has been renamed to BuildOutputWidget * AntOutputWidgetTest has been renamed to BuildOutputWidgetTest * xsl/ant.xsl has been moved to reporting/dashboard/webapp/xsl/buildoutput.xsl * The documentation for dashboard widgets has been updated to removed the "deprecated" notice Note that
Hi Joe,
I'm a dashboard neophyte, but although xsl/ant.xsl is named xsl/buildoutput.xsl now, it is still very "Ant specific", no? One of the recurring problems with Dashboard is it assume and AntBuilder (as opposed to Maven, Exec, etc), so I'm just trying to clarify which parts are still "Ant centric" and build are truly generic "Build" in nature. The ideal of a Builder neutral output widget may not make sense, but we should at least be clear on what parts are reusable (if any) and what parts are tightly coupled to a specific builder. Thanks! Dan Hi Dan,
I think the widget actually *is* quite generic. As long as the builder output ends up in the CC log file under the <build> element, this widget will display something. I know that this works for the "ant" and "exec" builds, but I haven't tested it with any of the other builders. I'm assuming that they must have their build output end up in a similar place of the CC log file. As a bit of background, I was originally using this patch to display output from the "exec" builder, which was calling out to a custom build program we were using (submitting compilation requests to a mainframe!). The developers of that system were confused by the tab label "Ant Output", but "Build Output" was much more logical to them. I have since switch to using Ant to wrap calls to the custom build tool, since I need a bit better control over input parameters. Even so, I think "Build Output" is still more understandable to the mainframe developers. Cheers, Joe Thanks Dan! I've tested out the changes locally on the ConnectFour project, and it appears to do what I expect.
Are you interested in another patch to add this widget to the default dashboard-config.xml? Cheers, Joe | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
If the CC Devs are receptive, there are a couple of other changes I would like to make:
* Change the name of the class from "AntOutputWidget" to "BuildOutputWidget" (and change the associated text on the widget tab), as this widget can handle builders other than Ant
* Make some tweaks to the XSL file so that it handles output from the <exec> builder more gracefully (for example, don't try and report the Ant version properties if they aren't available)