History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CC-612
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: David Jackman
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
CruiseControl

ignoreFiles attribute of modificationset config element only considers the first file for each Modification

Created: 07/Mar/07 07:16 AM   Updated: 19/Apr/07 09:02 AM
Component/s: Core Application
Affects Version/s: 2.5
Fix Version/s: 2.6.2

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
File Attachments: 1. Text File CC-612.patch (9 kb)



 Description  « Hide
The code that processes the ignoreFiles list checks each Modification in the list to see if it matches the ignoreFiles patterns, and throws the Modification out if it does. However, Modification represents a list of files, not just one, and this code only checks the first file in that list. (Indeed, there isn't even a method in Modification to expose the entire list of files.)

 All   Comments   Work Log   Change History      Sort Order:
David Jackman [07/Mar/07 07:42 AM]
This doesn't matter if the source control provider doesn't put multiple files in a single Modification (which CVS doesn't). Perforce does. I haven't used the other source control providers.

David Jackman [06/Apr/07 09:14 AM]
Attaching a patch that fixes the problem. The patch includes unit tests.

Paul Julius [19/Apr/07 09:02 AM]
Committed. Thanks.