[#CC-268] [PATCH] Add Ant style launcher

CruiseControl

[PATCH] Add Ant style launcher

Created: 11/Jul/05 03:32 PM Updated: 19/Nov/08 06:28 PM

Component/s:

Core Application

Affects Version/s:

2.3

Fix Version/s:

2.6

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

File Attachments:

cc_launcher_patch.txt (39 kb)

Issue Links:

Relationship

This issue Relates to:
	~~CC-400~~ internal ant can't create optional ta...
	~~CC-720~~ Need to provide directory for classes...
	~~CC-477~~ Remove the class-path in the cruiseco...

Description

« Hide

Hi all,

I've attached a patch which adds an Ant style launcher jar to
CruiseControl. Hopefully, if this works out, it should solve a lot of
the classpath problems - including command line length limits on
Windows.

It could also make things easier to move to a different packaging
structure in the future (should we choose to do so).

Note that I have had very little time to test this - in fact it's
completely untested on Unix platforms, so use with care!!!

I'm submitting this in the hopes that others will join in, give it a
try, and help me clean it up a bit. I don't expect that it's ready for
submission as it sits.

If you are familiar with Ant, then this will seem very familiar. The
launcher supports the same basic options with one additional one to
deal with the fact that CC seperates it's jars into two different
directories (dist and lib). Jars are searched in the following order:

1. Anything given on the command line using '-lib'.
2. Any jars in the per-user directory ($HOME/.cruisecontrol/lib).
3. All jars in the installation dist dir.
4. All jars in the installation lib dir

NOTE: I didn't modify the Ant Locator class to handle nested lib dirs,
so if you want to use the internal version of Ant, you'll have to add
the ant-launcher.jar using the '-lib' option.

Many thanks,

Robert

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Robert J. Smith [11/Jul/05 03:33 PM]

First crack at it.

[ Permlink | « Hide ]

Jeffrey Fredrick [18/Oct/05 11:04 PM]

I'm taking myself off the assignment list only because I haven't had the time to do the merge and local testing. I'm very much in favor of it being merged, so if anyone else wants to grab it feel free.

if nobody else does I'll grab it when I have the opportunity to test a bit.

[ Permlink | « Hide ]

Jeffrey Fredrick [28/Jan/06 08:55 AM]

I think we should try and do this for 2.4.1

[ Permlink | « Hide ]

Jeffrey Fredrick [28/Jan/06 09:01 AM]

using an ant style launcher (~~CC-268~~) should allow us to more easily add the required jars to the system classpath (~~CC-400~~).

[ Permlink | « Hide ]

Jerome Lacoste [21/Apr/06 04:22 AM]

- I don't like to introduce code copied from ant. Isn't there a library we can reuse instead? The only one I know of is classworlds, but I am not sure it fits with these needs. http://classworlds.codehaus.org/launchusage.html

- is this solution still flexible? What if one wants to add directories like CC_HOME/etc or something else to the CLASSPATH (e.g. for resource loading)

[ Permlink | « Hide ]

Jerome Lacoste [21/Apr/06 04:44 AM]

and -1 on having this in 2.5 if it hasn't been seriously tested on all plaftorms.

[ Permlink | « Hide ]

Jason Yip [21/Apr/06 06:46 AM]

This one doesn't seem necessary for 2.5 so I'm okay with deferring especially if we want to investigate alternate approaches.

[ Permlink | « Hide ]

Robert J. Smith [21/Apr/06 07:36 AM]

For what it's worth:

> is this solution still flexible? What if one wants to add directories like CC_HOME/etc or something else to the CLASSPATH (e.g. for resource loading)

Yes, you can pass in multiple "-dir" arguments to point to any directories you like.

If no solution exists, perhaps we can contribute our own library (or work with the Ant list to come up with a common implementation) to the Apache commons project . At the time I wrote this, I couldn't find a pre-packaged solution.

[ Permlink | « Hide ]

Jeffrey Fredrick [23/Apr/06 02:37 PM]

~~CC-400~~ is a very serious problem. if ~~CC-268~~ (or some similar solution) doesn't go in for 2.5 then we should manually add all the ant libs to the classpaths. (yuck).

[ Permlink | « Hide ]

Robert J. Smith [24/Apr/06 07:58 AM]

Adding all of the Ant jars will likely exceed the command line length limitation on some Windows versions.

[ Permlink | « Hide ]

Jason Yip [22/Jun/06 03:35 AM]

Upping the priority just because jar upgrades is currently horrendous

[ Permlink | « Hide ]

Jeffrey Fredrick [03/Jul/06 10:46 AM]

Jason, you've currently got ownership of this in Jira. Are you thinking you'll be able to get this done in the next week or so, in time for 2.6?

[ Permlink | « Hide ]

Jason Yip [03/Jul/06 04:13 PM]

Sure, I'll commit it but I'll probably need some help testing.

[ Permlink | « Hide ]

Bure T [26/Mar/07 01:04 PM]